Migration failure during reaction migration from gitea#13344
Merged
techknowlogick merged 3 commits intoOct 29, 2020
Merged
Conversation
A failure during migrating reactions should not cause failure of migration. Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
6 tasks
Contributor
Author
|
I've made this backport to v1.12 - only for the second & third commit in this PR - the reactions API should check the correct permission. |
GiteaBot
added
the
lgtm/need 2
zeripath
changed the title
lunny
approved these changes
Oct 29, 2020
GiteaBot
added
lgtm/need 1
6543
approved these changes
Oct 29, 2020
GiteaBot
added
lgtm/done
Member
|
🚀 |
6543
added
the
topic/repo-migration
Member
|
🚀 |
Codecov Report
@@ Coverage Diff @@
## master #13344 +/- ##
==========================================
- Coverage 42.11% 42.11% -0.01%
==========================================
Files 689 689
Lines 75845 75851 +6
==========================================
Hits 31943 31943
- Misses 38668 38674 +6
Partials 5234 5234
Continue to review full report at Codecov.
|
techknowlogick
added a commit
to techknowlogick/gitea
that referenced
this pull request
Oct 29, 2020
* Migrating reactions is just not that important A failure during migrating reactions should not cause failure of migration. Signed-off-by: Andrew Thornton <art27@cantab.net> * When checking issue reactions check the correct permission Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
techknowlogick
added
the
backport/done
techknowlogick
added a commit
to techknowlogick/gitea
that referenced
this pull request
Oct 29, 2020
* Migrating reactions is just not that important A failure during migrating reactions should not cause failure of migration. Signed-off-by: Andrew Thornton <art27@cantab.net> * When checking issue reactions check the correct permission Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Contributor
Author
|
Damn this is missing the last commit! There's another place in the same file that has the wrong check |
Contributor
Author
|
Is also the wrong permission check. It appears that the last commit in the branch didn't get pushed up - not sure why! |
techknowlogick
added a commit
that referenced
this pull request
Oct 29, 2020
* Migrating reactions is just not that important A failure during migrating reactions should not cause failure of migration. Signed-off-by: Andrew Thornton <art27@cantab.net> * When checking issue reactions check the correct permission Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: zeripath <art27@cantab.net>
zeripath
added a commit
to techknowlogick/gitea
that referenced
this pull request
Oct 29, 2020
Unfortunately my final push to go-gitea#13344 didn't register - or I failed to push it properly. GetIssueCommentReactions in routers/api/v1/repo/issue_reaction.go also makes the same mistake.
This was referenced Oct 29, 2020
Member
|
v1.12 backport is #13346 @techknowlogick why did you remove the label? |
techknowlogick
added a commit
that referenced
this pull request
Oct 29, 2020
* Migration failure during reaction migration from gitea (#13344) * Migrating reactions is just not that important A failure during migrating reactions should not cause failure of migration. Signed-off-by: Andrew Thornton <art27@cantab.net> * When checking issue reactions check the correct permission Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io> * Delete gitea_downloader.go * Backport #13349 Unfortunately my final push to #13344 didn't register - or I failed to push it properly. GetIssueCommentReactions in routers/api/v1/repo/issue_reaction.go also makes the same mistake. Co-authored-by: zeripath <art27@cantab.net>
6543
added
the
skip-changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two problems in #13262 which is a situation whereby a migration fails due to reactions migration failing.
Fix #13262
Signed-off-by: Andrew Thornton art27@cantab.net